fix(cli): disable global gitignore during tauri.conf.* lookup#8688
Merged
Conversation
There are cases when people use git to manage their dotfiles in the home directory. When a tauri projects uses other name than `src-tauri` for the rust source code, the lookup may fail if there's a global gitignore.
amrbashir
reviewed
Jan 29, 2024
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Could you also add a change file in .changes directory?
amrbashir
approved these changes
Jan 29, 2024
|
I'm not sure what your current backport strategy is but could this be back ported to v1 perchance? Or is v1 completely frozen? |
Member
|
v1 is still open for backports, we just don't work on backports that much ourselves and rely more on PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases when people use git to manage their dotfiles in the home directory. When a tauri projects uses other name than
src-taurifor the rust source code, the lookup may fail if there's a global gitignore.This PR aims to fix that.