fix(cli): Ignore query parameter in dev server #8697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
previously approved these changes
Jan 29, 2024
amrbashir
reviewed
Jan 29, 2024
amrbashir
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8148
additional ref: https://discord.com/channels/616186924390023171/1201199918379974766
imho query parameters have no business being in frontend file names (same for
#but the browser doesn't send that part to the server so doesn't matter here).This should now also match the behavior after
tauri build.The asset protocol should be able to handle it fine due to the url encoding, so devs can still load files with weird filenames that aren't part of the frontend.