refactor(core)!: Window::close triggers RunEvent::CloseRequested#8710
Merged
lucasfernog merged 11 commits intodevfrom Jan 31, 2024
Merged
refactor(core)!: Window::close triggers RunEvent::CloseRequested#8710lucasfernog merged 11 commits intodevfrom
lucasfernog merged 11 commits intodevfrom
Conversation
amrbashir
reviewed
Jan 30, 2024
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
previously approved these changes
Jan 30, 2024
Member
Author
|
Gonna work on adding the destroy API here too |
Contributor
|
@amrbashir @FabianLars updated with the destroy API |
amrbashir
previously approved these changes
Jan 31, 2024
amrbashir
approved these changes
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Window::close function now triggers the close requested event so devs can intercept it. To force close a window (previous behavior), use Window::destroy instead.