fix(core): macos #5122 app.runtime panic in app.set_activation_policy#8713
Merged
lucasfernog merged 3 commits intoFeb 2, 2024
Merged
Conversation
lucasfernog
approved these changes
Feb 2, 2024
lucasfernog
left a comment
Member
There was a problem hiding this comment.
Pushed a change to make it work when the app is running too. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a: this line runs firstb: app.run will take the app.runtime as intauri/core/tauri/src/app.rs
Line 875 in 00e1567
c: theset_activation_policywill try to getapp.runtimeandunwrap, but now, theapp.runtimeis None and the program panic.I add an
if lettoset_activation_policy. This will causecignored silently, maybe we need a better approach.And it seems the bug is not related to
window.show()in the original issue, whether before or after the multi web view refactor c77b403.