Skip to content

fix(tauri) ensure css content is loaded inside a string#884

Merged
lucasfernog merged 1 commit intodevfrom
fix/load-asset-css
Jul 22, 2020
Merged

fix(tauri) ensure css content is loaded inside a string#884
lucasfernog merged 1 commit intodevfrom
fix/load-asset-css

Conversation

@chippers
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
CSS assets cannot load with loadAsset because the CSS content is being injected raw. This change

  1. injects CSS content inside of a string
  2. reduces interpolation to a single instance

Signed-off-by: Chip Reed <chip@chip.sh>
@chippers chippers requested a review from a team as a code owner July 22, 2020 17:10
@chippers chippers requested a review from a team July 22, 2020 17:10
@lucasfernog lucasfernog merged commit e3e2e39 into dev Jul 22, 2020
@lucasfernog lucasfernog deleted the fix/load-asset-css branch July 22, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants