Skip to content

fix(bundler) webview dll not being bundled, fixes #875#889

Merged
lucasfernog merged 2 commits intodevfrom
fix/webview-dll
Jul 24, 2020
Merged

fix(bundler) webview dll not being bundled, fixes #875#889
lucasfernog merged 2 commits intodevfrom
fix/webview-dll

Conversation

@lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner July 24, 2020 04:02
@lucasfernog lucasfernog requested a review from a team July 24, 2020 04:02
@lucasfernog lucasfernog merged commit a00ac02 into dev Jul 24, 2020
@lucasfernog lucasfernog deleted the fix/webview-dll branch July 24, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants