fix(bundler): remove fallback for license_file#8948
Conversation
There was a problem hiding this comment.
I was actually doing the same pull request just now 😄
Or actually, I was changing the RPM bundle to use the restored license() function instead of license_file(), as RPM License tag is meant to contain a license identifier (e.g SPDX identifier), not a license file content.
It might also be good to add this RPM change in the changelog too.
amrbashir
force-pushed
the
fix/bundler/disable-license-file-fallback
branch
from
6f6206b to
4b4309f
Compare
olivierlemasle
left a comment
olivierlemasle
left a comment
There was a problem hiding this comment.
👍
Just add perhaps the RPM bug fix in the changelog (since the implementation of the new settings structure, the License tag of RPM bundles included the whole time when license_file is defined)
lucasfernog
left a comment
lucasfernog
left a comment
There was a problem hiding this comment.
we should document this behavior in the future
That's unfortunate, in the future could you reach out in discord or the issue and I will assign you? just so we don't work on the same thing. We appreciate your help <3. |
|
It is partially my fault too, I will also start assigning myself before working on something |
3 participants
closes #8944