Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundler): remove fallback for license_file #8948

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

amrbashir
Copy link
Member

closes #8944

@amrbashir amrbashir requested a review from a team as a code owner February 22, 2024 15:36
Copy link
Contributor

@olivierlemasle olivierlemasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually doing the same pull request just now 😄

Or actually, I was changing the RPM bundle to use the restored license() function instead of license_file(), as RPM License tag is meant to contain a license identifier (e.g SPDX identifier), not a license file content.

It might also be good to add this RPM change in the changelog too.

tooling/bundler/src/bundle/linux/rpm.rs Outdated Show resolved Hide resolved
@amrbashir amrbashir force-pushed the fix/bundler/disable-license-file-fallback branch from 6f6206b to 4b4309f Compare February 22, 2024 17:11
Copy link
Contributor

@olivierlemasle olivierlemasle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just add perhaps the RPM bug fix in the changelog (since the implementation of the new settings structure, the License tag of RPM bundles included the whole time when license_file is defined)

lucasfernog
lucasfernog previously approved these changes Feb 22, 2024
Copy link
Member

@lucasfernog lucasfernog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should document this behavior in the future

@amrbashir
Copy link
Member Author

I was actually doing the same pull request just now 😄

That's unfortunate, in the future could you reach out in discord or the issue and I will assign you? just so we don't work on the same thing. We appreciate your help <3.

@amrbashir
Copy link
Member Author

It is partially my fault too, I will also start assigning myself before working on something

@lucasfernog lucasfernog merged commit 84c783f into dev Feb 22, 2024
15 checks passed
@lucasfernog lucasfernog deleted the fix/bundler/disable-license-file-fallback branch February 22, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] [NSIS] License agreement screen cannot be omitted
3 participants