feat(core): always use child webviews on the unstable feature#9059
Merged
lucasfernog merged 2 commits intodevfrom Mar 4, 2024
Merged
feat(core): always use child webviews on the unstable feature#9059lucasfernog merged 2 commits intodevfrom
lucasfernog merged 2 commits intodevfrom
Conversation
amrbashir
reviewed
Mar 4, 2024
amrbashir
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the WebviewWindow implementation to always use wry's child webview implementation when the
unstablefeature flag is enabled. This enhances flexibility for app developers, allowing a WebviewWindow to be transformed to a multiwebview window and vice versa, reparent a webview from a WebviewWindow to another window etc.