Skip to content

chore: remove unstable log features & use qualified log::<macro> path - #9069

Merged
amrbashir merged 3 commits into
devfrom
chore/log-qualified-path
Mar 4, 2024
Merged

chore: remove unstable log features & use qualified log::<macro> path#9069
amrbashir merged 3 commits into
devfrom
chore/log-qualified-path

Conversation

@amrbashir

Copy link
Copy Markdown
Member

No description provided.

@amrbashir
amrbashir requested a review from a team as a code owner March 4, 2024 18:26

@lucasfernog lucasfernog left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should consider adding tauri-plugin-log by default (on debug) on the app template.. it's now required to see the log::error messages (plus it's kinda required on mobile, otherwise app logs/stdout aren't visible on android and iOS)

@amrbashir

Copy link
Copy Markdown
Member Author

maybe we could add an internal logger that is activated on debug only. I don't want to pollute the template with another plugin, I am already dissatisfied with the shell plugin being there by default.

@amrbashir
amrbashir merged commit 9aa0d6e into dev Mar 4, 2024
@amrbashir
amrbashir deleted the chore/log-qualified-path branch March 4, 2024 19:22
@lucasfernog

Copy link
Copy Markdown
Member

shell is there only for CTA right? and yes it sucks

@amrbashir

Copy link
Copy Markdown
Member Author

yeah only in CTA template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants