Fix #912 multibyte character breaks message#914
Merged
jbolda merged 3 commits intotauri-apps:devfrom Aug 1, 2020
lancetarn:fix/912-writefile-unicode
Merged
Fix #912 multibyte character breaks message#914jbolda merged 3 commits intotauri-apps:devfrom lancetarn:fix/912-writefile-unicode
jbolda merged 3 commits intotauri-apps:devfrom
lancetarn:fix/912-writefile-unicode
Conversation
jbolda
approved these changes
Aug 1, 2020
Member
jbolda
left a comment
jbolda
left a comment
There was a problem hiding this comment.
Looks good to me!
Passing test: https://github.com/tauri-apps/tauri/pull/914/checks?check_run_id=936078128#step:6:53
nothingismagick
approved these changes
Aug 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)Other information:
Not sure if this is exactly what is called for, but this is working for me.