-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(core): scope JS resources to the webview #9272
Conversation
I think it's easier if we added a state that is specific to a window/webview so each target has its own resource table. Currently there's a StateManager in the manager, but we can easily include one in the window or webview too (WebviewWindow can just use the window one). plus we should still use random resource IDs |
yeah this sounds better, however I still would like to keep a global resources table so I guess I will just remove
if the resources are scoped, we don't have to use random ids, is there any other reason to use random ids? |
we can check with the auditors later but I feel it's safer with random IDs. cc @chippers @tweidinger |
I did confirm with the auditors before opening the PR, they still need to re-test though |
Hardening in depth and reducing risk. I would strongly suggest to have it randomized as we don't know all the special use cases in finished apps. |
doesn't cost much to randomize it (we should already have a dependency on getrandom somewhere) |
totally forgot we already have a dependency on it, pushed the random changes |
No description provided.