Skip to content

fix(core): fix deadlock when using resources_table in menu/image/tray plugins#9379

Merged
amrbashir merged 4 commits intodevfrom
fix/core/deadlock-resources-table
Apr 15, 2024
Merged

fix(core): fix deadlock when using resources_table in menu/image/tray plugins#9379
amrbashir merged 4 commits intodevfrom
fix/core/deadlock-resources-table

Conversation

@amrbashir
Copy link
Copy Markdown
Member

closes #9369

@amrbashir amrbashir requested a review from a team as a code owner April 4, 2024 02:49
@morajabi
Copy link
Copy Markdown

anything blocking this?

@FabianLars
Copy link
Copy Markdown
Member

Whoops, my bad. I thought I approved this already.

@FabianLars
Copy link
Copy Markdown
Member

Actually on a second look, do we need to document the required resource table source after the scoped table pr or does that not matter?
(I'm having a rough time getting an overview on my phone rn...)

@morajabi
Copy link
Copy Markdown

this prevents us from updating to latest version, that's why I asked <3

@amrbashir
Copy link
Copy Markdown
Member Author

although not needed that much

Actually on a second look, do we need to document the required resource table source after the scoped table pr or does that not matter?

there is no hard requirement on which resource table is used, it will return an error if can't be found but I updated the documentation to recommend using the webview one

@amrbashir amrbashir merged commit c8a82ad into dev Apr 15, 2024
@amrbashir amrbashir deleted the fix/core/deadlock-resources-table branch April 15, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Context menu creation in Javascript is broken

3 participants