fix(core): fix deadlock when using resources_table in menu/image/tray plugins#9379
Merged
fix(core): fix deadlock when using resources_table in menu/image/tray plugins#9379
Conversation
|
anything blocking this? |
Member
|
Whoops, my bad. I thought I approved this already. |
Member
|
Actually on a second look, do we need to document the required resource table source after the scoped table pr or does that not matter? |
|
this prevents us from updating to latest version, that's why I asked <3 |
Member
Author
|
although not needed that much
there is no hard requirement on which resource table is used, it will return an error if can't be found but I updated the documentation to recommend using the webview one |
FabianLars
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9369