Set internal message ID to nextId after handling pending messages#9463
Merged
lucasfernog merged 5 commits intotauri-apps:devfrom Apr 21, 2024
GCRev:bugfix/core-ipc-message-id
Merged
Set internal message ID to nextId after handling pending messages#9463lucasfernog merged 5 commits intotauri-apps:devfrom GCRev:bugfix/core-ipc-message-id
lucasfernog merged 5 commits intotauri-apps:devfrom
GCRev:bugfix/core-ipc-message-id
Conversation
Member
|
I'm not really familiar with this code so i leave the review to others, but from my testing this PR fixes #9463 🥳 |
Member
|
cc @lucasfernog |
|
Thank you! This works for me too |
lucasfernog
previously approved these changes
Apr 21, 2024
lucasfernog
approved these changes
Apr 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an existing mechanism for handling message overflow, but when triggered, it does not update the internal ID for the next message that comes in, which stops any further messages from being handled. I found this while working with the shell plugin and integrating a sidecar that sends a lot of responses for each request.
In my testing, this single line fix solves the problem.
closes tauri-apps/plugins-workspace#1169