refactor(nsis): use nsis's built-in com plugin instead of ApplicationID plugin #9527
Conversation
| WinShell::UninstAppUserModelId "${BUNDLEID}" | ||
| WinShell::UninstShortcut "$DESKTOP\${MAINBINARYNAME}.lnk" |
There was a problem hiding this comment.
We already remove the desktop shortcut on Line 691
We shouldn't remove the shortcut on uninstall, otherwise when updating it will be removed and never re-created again. We should detect if we are updating and skip removing the shortcut.
There was a problem hiding this comment.
This is what they did in their example, I don't know if we should do it or not, I can take a look tomorrow
I don't think uninstall runs on update, right?
There was a problem hiding this comment.
We already remove the desktop shortcut on Line 691
Oh, was on mobile, forgot that this (UninstShortcut) is to unpin the shortcut
|
I believe this will require us to upload |
|
I could take a look tomorrow, but I'm really getting tired of fighting nsi scripts 😂, this plugin is pretty small, and does the job, if we can take it I think we should |
No problem, just let me know and I can fight it for you |
Legend-Master
changed the title
…ID plugin (#9527) * Use WinShell instead of ApplicationID * Uninst shortcut before removing start menu one * Use nsis's buit-in com plugin instead of WinShell * Remove download ApplicationID code * Add change file * Clippy and format * Allow dead code on extract_zip * Qualify extract_zip path to make clippy happy * Move macro up
Use nsis's built-in com plugin instead of ApplicationID plugin, this reduces the installer size by 150-200 KB, and also fixes pinned shortcut not getting cleaned up on uninstall