Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tray): add TrayIcon::rect method #9615

Merged
merged 5 commits into from
May 3, 2024

Conversation

pronebird
Copy link
Contributor

Follow up PR on tauri-apps/tray-icon#147

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Could you also add a change file in .changes directory?

@pronebird
Copy link
Contributor Author

Thank you, Could you also add a change file in .changes directory?

In a minute

@pronebird pronebird force-pushed the macos-tray-frame branch 3 times, most recently from 8dd131c to d25040d Compare April 30, 2024 14:14
@pronebird pronebird requested a review from amrbashir April 30, 2024 14:16
@pronebird
Copy link
Contributor Author

Not sure how exactly you name .md files under changes/. Please have another look.

Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
@amrbashir
Copy link
Member

Once a new release of tray-icon crate is made, we can merge this

@pronebird pronebird requested a review from amrbashir May 2, 2024 16:01
amrbashir
amrbashir previously approved these changes May 3, 2024
@amrbashir amrbashir changed the title feat: add call to TrayIcon::rect() feat(tray): add TrayIcon::rect method May 3, 2024
@amrbashir amrbashir merged commit 07ff78c into tauri-apps:dev May 3, 2024
17 of 19 checks passed
@amrbashir
Copy link
Member

Thank you

@pronebird pronebird deleted the macos-tray-frame branch May 5, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants