feat: configure a default runtime for menu and tray icon types #9630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscartbeaumont
changed the title
amrbashir
approved these changes
May 1, 2024
amrbashir
force-pushed
the
default-generic-for-menu
branch
from
4ebf179 to
e7163dd
Compare
amrbashir
approved these changes
May 1, 2024
amrbashir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed in Tauri v2 it's common for the
R: Runtimeto be set totauri::Wry. This is great for users who don't know or care what a runtime is.For example
AppHandle,Appand more types do this using thedefault_runtimemacro.I think this same default runtime makes sense on the menu type so this PR implements that.