fix: schemars 0.8.18 compatibility - #9676
Merged
Merged
Conversation
Member
|
Thank you for looking into an actual fix instead of going the lazy road like i did in the pr you linked 🙃 2 things before i can merge this though:
edit: also something's up with the cli lockfile(?) - if you can't find the issue i can take a look once you signed your commits (because if i push something, signing your old commits will be harder) |
|
|
FabianLars
added a commit
that referenced
this pull request
May 6, 2024
backport of #9676 Co-authored-by: Hankung <73242257+Hankung7183@users.noreply.github.com>
Member
|
i have to release a new v1 version first to make the cli compile, please bear with me lol |
|
|
FabianLars
added a commit
that referenced
this pull request
May 6, 2024
* fix: schemars 0.8.18 compatibility backport of #9676 Co-authored-by: Hankung <73242257+Hankung7183@users.noreply.github.com> * fix clippy lol --------- Co-authored-by: Hankung <73242257+Hankung7183@users.noreply.github.com>
FabianLars
approved these changes
May 6, 2024
Member
|
sorry for the long delay, ci is taking ages today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #9677 #9675 #9674 #9678