feat: adds monitor_from_point method#9770
Merged
amrbashir merged 14 commits intotauri-apps:devfrom May 14, 2024
Merged
Conversation
clearlysid
commented
May 14, 2024
clearlysid
commented
May 14, 2024
Contributor
Author
|
If someone can guide me to resolve the above comments, this PR will be ready to review 💫 |
amrbashir
requested changes
May 14, 2024
Member
amrbashir
left a comment
amrbashir
left a comment
There was a problem hiding this comment.
Thanks for contributing, LGTM, just need to get the documentation consistent and should be good to go. You also need to run yarn build and yarn format inside tooling/api
Contributor
Author
|
All good from my end ✅ |
amrbashir
reviewed
May 14, 2024
amrbashir
approved these changes
May 14, 2024
Signed-off-by: clearlysid <siddharth99c@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
Co-authored-by: Amr Bashir <amr.bashir2015@gmail.com>
amrbashir
force-pushed
the
feat/monitor-from-point
branch
from
dd5c909 to
6222f0e
Compare
amrbashir
approved these changes
May 14, 2024
Contributor
Author
|
wow how'd you do this? here I thought I needed to go back and re-commit each one again with signature 😂 — nice work! |
Member
|
Check this for the command I use https://superuser.com/questions/397149/can-you-gpg-sign-old-commits/1123928#1123928 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes this Tao method in Tauri too. Merging this closes #3057 and unblocks spyglass-search/spyglass#312