chore: emit rustc-check-cfg for nightly #9850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfernog
reviewed
May 22, 2024
| @@ -211,7 +211,9 @@ fn copy_frameworks(dest_dir: &Path, frameworks: &[String]) -> Result<()> { | |||
| // creates a cfg alias if `has_feature` is true. | |||
| // `alias` must be a snake case string. | |||
| fn cfg_alias(alias: &str, has_feature: bool) { | |||
There was a problem hiding this comment.
we pretty much have this function on all crates, can you also update those? just search for cargo:rustc-cfg
|
is it okay to bump MSRV to 1.77? seems too soon even for beta |
|
Its not bumping the MSRV, since the old syntax style instructions will still be emitted as well |
|
ah my bad, didn't look carefully and thought we are replacing old syntax. You even wrote that in the PR description 🤦♂️ |
lucasfernog
changed the title
|
We must use |
lucasfernog
changed the title
lucasfernog
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old
cargo:instruction syntax has been deprecated with version 1.77 and newer features (such as thecheck-cfgfeature introduced in 1.79) require the new double coloncargo::syntax.This change keeps the old syntax around since it is ignored on newer versions and still necessary for our MSRV policy.