feat(bundler): support custom sign command on Windows#9865
Merged
lucasfernog merged 12 commits intodevfrom May 24, 2024
Merged
Conversation
lucasfernog
reviewed
May 24, 2024
lucasfernog
reviewed
May 24, 2024
lucasfernog
approved these changes
May 24, 2024
This was referenced May 27, 2024
Closed
anatawa12
pushed a commit
to anatawa12/tauri
that referenced
this pull request
Jun 6, 2024
* feat(bundler): support custom sign command on Windows closes tauri-apps#7188 closes tauri-apps#9578 * fix double quotes * fix build * fix build * clippy * Update sign.rs * clippy && replace `winreg` with `windows-registry` * remove log [skip ci] * Apply suggestions from code review * tweak arg so path with spaces work on macOS * create nsis toolset paths --------- Co-authored-by: Lucas Nogueira <lucas@tauri.app>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7188
closes #9578