Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nsis): add an option to disable compression #9932

Merged
merged 7 commits into from
Jun 5, 2024
Merged

feat(nsis): add an option to disable compression #9932

merged 7 commits into from
Jun 5, 2024

Conversation

Legend-Master
Copy link
Contributor

No description provided.

@Legend-Master Legend-Master requested a review from a team as a code owner May 31, 2024 09:17
amrbashir
amrbashir reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what this PR is trying to solve, it is more or less looks like a refactor to me.

@Legend-Master
Copy link
Contributor Author

Before

image

After

image

@amrbashir
Copy link
Member

amrbashir commented Jun 5, 2024 •
edited
Loading

That still not an issue, if user specifies null we default back to lzma, or maybe we need to actually make null disable compression

@Legend-Master
Copy link
Contributor Author

Isn't this about correcting the schema?

@amrbashir
Copy link
Member

amrbashir commented Jun 5, 2024 •
edited
Loading

You're right, but I think the schema is kinda correct, maybe just missing a documentation to explain that using null will default to lzma.

This PR has a breaking change because it changed the field from Option<T> to T and I am afraid some users may want to be able to disable compression and if that were to be requested, we will have to make another breaking change, so maybe we should take the opportunity to cover that case as well?

@Legend-Master
Copy link
Contributor Author

Right, we can include no compression as an option here

@Legend-Master Legend-Master changed the title fix(nsis): default nsis compression schema is null feat(nsis): add an option to disable compression Jun 5, 2024
@amrbashir amrbashir merged commit 3ab1709 into tauri-apps:dev Jun 5, 2024
33 checks passed
@amrbashir
Copy link
Member

Thank you

@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
pewsheen pushed a commit to pewsheen/tauri that referenced this pull request Jun 13, 2024
@Legend-Master @pewsheen
feat(nsis): add an option to disable compression (tauri-apps#9932)
b9d56cf
@Legend-Master Legend-Master deleted the nsis-default-compression-schema branch June 20, 2024 03:28
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Legend-Master @amrbashir