Skip to content

fix(core): add std feature to raw-window-handle#9954

Merged
amrbashir merged 2 commits intotauri-apps:devfrom
Legend-Master:std-raw-window-handle
Jun 4, 2024
Merged

fix(core): add std feature to raw-window-handle#9954
amrbashir merged 2 commits intotauri-apps:devfrom
Legend-Master:std-raw-window-handle

Conversation

@Legend-Master
Copy link
Contributor

Add std feature to raw-window-handle crate so that no default features can work

Reference: https://github.com/tauri-apps/plugins-workspace/actions/runs/9334978097/job/25730280072?pr=1402

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not sure how does enabling no-default-features affects raw-window-handle and I also can't reproduce the bug locally

@amrbashir
Copy link
Member

amrbashir commented Jun 4, 2024

NVM, I was using the wrong name for default-features, still not sure how are they related.

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jun 4, 2024

tauri uses thiserror to forward raw-window-handle's error, but this is only doable with std feature, currently we have it on tauri-runtime-wry which has tao which has raw-window-handle with std feature, but with not default features, we no longer depends on tauri-runtime-wry -> tao

@amrbashir amrbashir merged commit e6e17ad into tauri-apps:dev Jun 4, 2024
@Legend-Master Legend-Master deleted the std-raw-window-handle branch June 4, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants