Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpm): use product name for output package #9974

Merged
merged 3 commits into from
Jun 5, 2024
Merged

fix(rpm): use product name for output package #9974

merged 3 commits into from
Jun 5, 2024

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir requested a review from a team as a code owner June 4, 2024 22:27
@amrbashir
Copy link
Member Author

@FabianLars even though the product name is used for the output bundle, the main binary name is still used in the RPM manifest, I assume the main binary name affects how you call the binary from command line? can you test if this aligns with .deb?

@FabianLars
Copy link
Member

.deb:

  • .deb file uses productName as is
  • binary to invoke in console is from cargo.toml
  • apt knows the installed app as productName as kebab-case (!)

.rpm:

  • .rpm file uses productName as is
  • binary to invoke in console is from cargo.toml
  • dnf knows the installed app as name from cargo.toml (!)

@amrbashir
Copy link
Member Author

@FabianLars can you retest with the last commit?

@FabianLars
Copy link
Member

as far as i can tell it behaves the same now

@amrbashir amrbashir merged commit de7da04 into dev Jun 5, 2024
15 checks passed
@amrbashir amrbashir deleted the fix/bundler/rpm-output-path branch June 5, 2024 16:57
@github-actions github-actions bot mentioned this pull request Jun 5, 2024
Merged
pewsheen pushed a commit to pewsheen/tauri that referenced this pull request Jun 13, 2024
@amrbashir @pewsheen
fix(rpm): use product name for output package (tauri-apps#9974)
9c5d6fe 
* fix(rpm): use product name for output package

ref: tauri-apps#9375
ref: tauri-apps#9375 (comment)

* use kebab-case product-name for rpm

* fmt
@github-actions github-actions bot mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrbashir @FabianLars