fix(rpm): use product name for output package#9974
Merged
Conversation
Member
Author
|
@FabianLars even though the product name is used for the output bundle, the main binary name is still used in the RPM manifest, I assume the main binary name affects how you call the binary from command line? can you test if this aligns with |
Member
|
.deb:
.rpm:
|
Member
Author
|
@FabianLars can you retest with the last commit? |
Member
|
as far as i can tell it behaves the same now |
FabianLars
approved these changes
Jun 5, 2024
pewsheen
pushed a commit
to pewsheen/tauri
that referenced
this pull request
Jun 13, 2024
* fix(rpm): use product name for output package ref: tauri-apps#9375 ref: tauri-apps#9375 (comment) * use kebab-case product-name for rpm * fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #9375
ref: #9375 (comment)