Skip to content

fix(bundler) missing newline in deb desktop file generation (fix: #899, #925)#998

Merged
jbolda merged 3 commits intotauri-apps:devfrom
ho-ho-ho:patch-1
Aug 27, 2020
Merged

fix(bundler) missing newline in deb desktop file generation (fix: #899, #925)#998
jbolda merged 3 commits intotauri-apps:devfrom
ho-ho-ho:patch-1

Conversation

@ho-ho-ho
Copy link
Contributor

@ho-ho-ho ho-ho-ho commented Aug 27, 2020

What kind of change does this PR introduce? (check at least one)
fixes #899 and #925

  • Bugfix
  • Feature
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
the generated desktop file didn't work properly (especially if no short_description was given) since the newline was missing and the next line ended up as a category.

@ho-ho-ho ho-ho-ho requested a review from a team August 27, 2020 15:44
@ho-ho-ho ho-ho-ho changed the title fix(bundler) missing newline in deb desktop file generation (fix: #899) fix(bundler) missing newline in deb desktop file generation (fix: #899, #925) Aug 27, 2020
Copy link
Member

@jbolda jbolda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Would you please add a change file as well?

@ho-ho-ho ho-ho-ho requested a review from a team as a code owner August 27, 2020 17:56
@ho-ho-ho
Copy link
Contributor Author

Sure, I think this should do it :)

@jbolda
Copy link
Member

jbolda commented Aug 27, 2020

Cheers! Thanks!

@jbolda jbolda merged commit 37bcf5f into tauri-apps:dev Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop failed to exec

2 participants