fix(bundler) missing newline in deb desktop file generation (fix: #899, #925)#998
Merged
jbolda merged 3 commits intotauri-apps:devfrom Aug 27, 2020
Merged
fix(bundler) missing newline in deb desktop file generation (fix: #899, #925)#998jbolda merged 3 commits intotauri-apps:devfrom
jbolda merged 3 commits intotauri-apps:devfrom
Conversation
jbolda
requested changes
Aug 27, 2020
Member
jbolda
left a comment
There was a problem hiding this comment.
Thanks! Would you please add a change file as well?
add change file for PR tauri-apps#998
Contributor
Author
|
Sure, I think this should do it :) |
jbolda
approved these changes
Aug 27, 2020
Member
|
Cheers! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
fixes #899 and #925
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
the generated desktop file didn't work properly (especially if no
short_descriptionwas given) since the newline was missing and the next line ended up as a category.