Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(nsis): add an option to customize start menu folder #9994

Merged
merged 28 commits into from
Jun 26, 2024

Conversation

Legend-Master
Copy link
Contributor

Closes #9880

@Legend-Master Legend-Master marked this pull request as ready for review June 6, 2024 03:39
@Legend-Master Legend-Master requested a review from a team as a code owner June 6, 2024 03:39
@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jun 6, 2024

Current behavior should be

If old installer was using StartMenu/App/App.lnk and new installer uses:

  • With same folder name:
    • Everything stays the same
  • No additional folder or with a different folder name:
    • Nothing happens on /UPDATE
    • Create a new shortcut on manual install
    • Remove old and new shortcuts on uninstall

If old installer was using StartMenu/App.lnk and new installer uses:

  • With a folder name:
    • Nothing happens on /UPDATE
    • Create a folder and new shortcut on manual install
    • Remove old and new shortcuts on uninstall
  • No folder name:
    • Everything stays the same

core/tauri-utils/src/config.rs Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/windows/nsis.rs Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/windows/templates/installer.nsi Outdated Show resolved Hide resolved
.changes/nsis-start-menu-folder.md Outdated Show resolved Hide resolved
.changes/nsis-start-menu-folder.md Outdated Show resolved Hide resolved
@Legend-Master Legend-Master requested a review from amrbashir June 7, 2024 00:49
.changes/nsis-start-menu-folder-breaking.md Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/settings.rs Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/windows/templates/installer.nsi Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/windows/templates/installer.nsi Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/windows/templates/installer.nsi Outdated Show resolved Hide resolved
@Legend-Master Legend-Master requested a review from amrbashir June 25, 2024 01:44
@amrbashir amrbashir merged commit f21029b into tauri-apps:dev Jun 26, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] an option to not create a start menu folder for nsis installer
2 participants