Skip to content

feat!(nsis): add an option to customize start menu folder#9994

Merged
amrbashir merged 28 commits intotauri-apps:devfrom
Legend-Master:nsis-start-menu-folder
Jun 26, 2024
Merged

feat!(nsis): add an option to customize start menu folder#9994
amrbashir merged 28 commits intotauri-apps:devfrom
Legend-Master:nsis-start-menu-folder

Conversation

@Legend-Master
Copy link
Contributor

Closes #9880

@Legend-Master Legend-Master marked this pull request as ready for review June 6, 2024 03:39
@Legend-Master Legend-Master requested a review from a team as a code owner June 6, 2024 03:39
@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jun 6, 2024

Current behavior should be

If old installer was using StartMenu/App/App.lnk and new installer uses:

  • With same folder name:
    • Everything stays the same
  • No additional folder or with a different folder name:
    • Nothing happens on /UPDATE
    • Create a new shortcut on manual install
    • Remove old and new shortcuts on uninstall

If old installer was using StartMenu/App.lnk and new installer uses:

  • With a folder name:
    • Nothing happens on /UPDATE
    • Create a folder and new shortcut on manual install
    • Remove old and new shortcuts on uninstall
  • No folder name:
    • Everything stays the same

@Legend-Master Legend-Master requested a review from amrbashir June 7, 2024 00:49
@Legend-Master Legend-Master requested a review from amrbashir June 25, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] an option to not create a start menu folder for nsis installer

2 participants