From 3d3ea80808a327c546d8bbd97e06ef4b8feb32d0 Mon Sep 17 00:00:00 2001
From: "Ngo Iok Ui (Wu Yu Wei)" <yuweiwu@pm.me>
Date: Mon, 14 Nov 2022 03:13:56 +0800
Subject: [PATCH] On macOS, remove webview from window's NSView before dropping
 (#754)

---
 .changes/webview-remove.md   | 5 +++++
 src/webview/wkwebview/mod.rs | 2 ++
 2 files changed, 7 insertions(+)
 create mode 100644 .changes/webview-remove.md

diff --git a/.changes/webview-remove.md b/.changes/webview-remove.md
new file mode 100644
index 000000000..24c2d3ac2
--- /dev/null
+++ b/.changes/webview-remove.md
@@ -0,0 +1,5 @@
+---
+"wry": patch
+---
+
+On macOS, remove webview from window's NSView before dropping.
diff --git a/src/webview/wkwebview/mod.rs b/src/webview/wkwebview/mod.rs
index ec1517755..99f5f4923 100644
--- a/src/webview/wkwebview/mod.rs
+++ b/src/webview/wkwebview/mod.rs
@@ -880,6 +880,8 @@ impl Drop for InnerWebView {
         }
       }
 
+      // Remove webview from window's NSView before dropping.
+      let () = msg_send![self.webview, removeFromSuperview];
       let _: Id<_> = Id::from_retained_ptr(self.webview);
       let _: Id<_> = Id::from_retained_ptr(self.manager);
     }