Skip to content

Include 'sunos' to enable installation on SmartOS, Illumos, etc. #44

Closed
wants to merge 1 commit into from

2 participants

@notmatt
notmatt commented Apr 6, 2012

Or, since it's pure JS, removing the 'os' line seems like a good option.

In any case, all tests pass on SmartOS, and no problems in use.

# node runtests.js 
The "sys" module is now called "util". It should have a similar interface.
[RSS (2.0)]: passed
[Atom (1.0)]: passed
[Unquoted attributes]: passed
[Enforce empty tags]: passed
[XML Namespace]: passed
[Extra spaces in tag]: passed
[Ignore empty tags]: passed
[Single Tag 1]: passed
[Single Tag 2]: passed
[Only text]: passed
[Unescaped chars in script]: passed
[Comment within text within script]: passed
[Script source in comment]: passed
[Comment within text]: passed
[Postion data]: passed
[Singular attribute]: passed
[Text outside tags]: passed
[Options 'ignoreWhitespace' set to 'true']: passed
[Option 'verbose' set to 'false']: passed
[Basic test]: passed
[Unescaped chars in style]: passed
[Special char in comment]: passed
Total tests: 22
Failed tests: 0
@notmatt
notmatt commented Apr 6, 2012

Actually a bit of a conflict between npm behaviour and the spec here; the latter claims that 'solaris' is the valid os name for Solar-ish OSes, but npm likes sunos (which is the reported name for SmartOS).

@tautologistics
Owner

Thank you but I am just going to remove the "os" entry (1.7.6 coming shortly)

@notmatt
notmatt commented Apr 12, 2012

Sounds good to me, thanks!

@tautologistics
Owner

BTW - 1.7.6 is up on npm now. Just wrapping up work on 2.0 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.