Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Suppress ANSI colors #32

Closed
nelstrom opened this Issue · 6 comments

2 participants

@nelstrom

Out of the box, and using the default formatter, nodelint uses ANSI colors to mark error messages red in the console. It would be great if there was a way to suppress these. Two ideas spring to mind:

  • provide a --nocolor flag
  • and/or respect the NODE_DISABLE_COLORS environment variable

I'm not sure which is the best approach, but I've found similar issues filed for coffeescript and cli.

@Sannis
Collaborator

I think respect the NODE_DISABLE_COLORS is a good suggestion.

@Sannis Sannis referenced this issue from a commit in Sannis/nodelint
@Sannis Sannis Respect NODE_DISABLE_COLORS in default reporter, refs #32 654f41f
@Sannis
Collaborator

Only default reporter use ANSI coloring, so I move options to reporter and add NODE_DISABLE_COLORS check there.

Is it ok for you, @nelstrom?

@nelstrom

Nice work! Thanks for a quick turnaround on this issue.

@Sannis
Collaborator

It will be merged into tav/master if there is no other opinions.

@Sannis
Collaborator

Released.

@Sannis Sannis closed this
@nelstrom

Great news, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.