Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add py as dependency to remeditate AttributeError: module 'py' has no attribute 'io' #818

Merged
merged 4 commits into from Nov 7, 2022

Conversation

ahebrank
Copy link
Contributor

@ahebrank ahebrank commented Nov 2, 2022

See #816 .

pytest has removed py as a dependency as of 7.2.0 (pytest-dev/pytest#10396), but tavern still requires it. Test failures produce an internal error AttributeError: module 'py' has no attribute 'io' without this dependency.

ahebrank and others added 2 commits November 2, 2022 08:01
pytest has removed py as a dependency as of 7.2.0, but tavern still requires it
@michaelboulton
Copy link
Member

I think there is some issue with the way tox caching is working in the github action. I don't know why it keeps failing (due to it not actually installing py) when it's explicitly listed as a dependency

@michaelboulton michaelboulton merged commit 465c348 into taverntesting:master Nov 7, 2022
@ahebrank ahebrank deleted the patch-1 branch November 7, 2022 16:17
@i540608
Copy link

i540608 commented Nov 8, 2022

@michaelboulton Hi,
is it possible to remove the Py from the release dependencies and use different file for test dependencies, because the Py has quite high-level security vulnerability and it will trigger security scanners for my projects;

As the Py is itself deprecated, then it's highly likely that maintainers of the Py will not push the fix

@michaelboulton
Copy link
Member

It may be deprecated but pytest have also vendored part of the library pytest-dev/pytest#10396 , not the 'io' part which is also used by tavern. It means reaching into more internal pytest code.

michaelboulton added a commit that referenced this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants