Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Blocks and some modifications #26

Closed
wants to merge 14 commits into from
Closed

Conversation

@danielfsc
Copy link
Contributor

@danielfsc danielfsc commented Jul 23, 2013

Hi David,
Here are my new blocks and modifications that I made in ardublock.

See Ya

Daniel

@cumt49
Copy link

@cumt49 cumt49 commented Jul 23, 2013

thx

------------------ 原始邮件 ------------------
发件人: "danielfsc"notifications@github.com;
发送时间: 2013年7月23日(星期二) 中午11:05
收件人: "taweili/ardublock"ardublock@noreply.github.com;

主题: [ardublock] New Blocks and some modifications (#26)

Hi David,
Here are my new blocks and modifications that I made in ardublock.

See Ya

Daniel

You can merge this Pull Request by running
git pull https://github.com/danielfsc/ardublock master
Or view, comment on, or merge it at:

#26

Commit Summary

Try 1

New Blocks

New Files

New Files

Delete ardublock.properties~

Delete ardublock.properties_old

Delete ardublock.xml_old

Delete ardublock.xml~

Delete ardublock_pt_BR.properties~

Delete block-mapping.properties~

File Changes

 A     src/main/java/com/ardublock/translator/block/CodeHeadBlock.java     (26)   

 A     src/main/java/com/ardublock/translator/block/CodeLoopBlock.java     (24)   

 A     src/main/java/com/ardublock/translator/block/CodeSetupBlock.java     (25)   

 A     src/main/java/com/ardublock/translator/block/SerialPrintBlock.java     (24)   

 A     src/main/java/com/ardublock/translator/block/SerialReadBlock.java     (24)   

 M     src/main/resources/com/ardublock/block/ardublock.properties     (13)   

 M     src/main/resources/com/ardublock/block/ardublock.xml     (306)   

 M     src/main/resources/com/ardublock/block/ardublock_pt_BR.properties     (34)   

 A     src/main/resources/com/ardublock/block/ardublock_pt_BR.properties_old     (149)   

 M     src/main/resources/com/ardublock/block/block-mapping.properties     (8)   

Patch Links:

https://github.com/taweili/ardublock/pull/26.patch

https://github.com/taweili/ardublock/pull/26.diff

@taweili
Copy link
Owner

@taweili taweili commented Aug 2, 2013

Hi Daniel,

Could you give me a little bit more about the change? Thanks a lot for the contribution.

David

@danielfsc
Copy link
Contributor Author

@danielfsc danielfsc commented Aug 2, 2013

Hi David,
Basically I changed the colors and side menu structure.

  1. I split the menu Operators into two menus: Mathematical Operators and Logical Operators.
  2. Move the delay function to Control and change the color to Yellow.
  3. Create the menu Especial with 3 function: One where you can write a code directly on the header, other two setup and the last one to loop. Now the user can include a Library or others stuffs without a specific block.
  4. I create a For/ Repeat loop where the user can set a variable name for the counter.
  5. In Logical Operators I create two new blocks for == and != where you can put a boolean variable.

I'm kind of stupid so I have a huge problem to upload the code to github. I don't upload all this functions to github yet. If you like you can get the code directly from my Dropbox: https://www.dropbox.com/sh/hp2l7prvj0ht7k4/reKp69Mp-N

See ya

Daniel

@taweili
Copy link
Owner

@taweili taweili commented Aug 2, 2013

Hi Daniel,

These sounds amazing! It would be great if you could upload all to your branch on github to make it easier for us to integrate the code into the development branch. Thanks a lot!

David

@danielfsc
Copy link
Contributor Author

@danielfsc danielfsc commented Aug 2, 2013

I upload my files to github. Good Luck.

2013/8/2 David Li notifications@github.com

Hi Daniel,

These sounds amazing! It would be great if you could upload all to your
branch on github to make it easier for us to integrate the code into the
development branch. Thanks a lot!

David


Reply to this email directly or view it on GitHubhttps://github.com//pull/26#issuecomment-22036347
.

Dr. Daniel Girardi
Instituto de Ciências Exatas - Depto de Física
Universidade Federal Fluminense
Rua Des. Ellis Hermydio Figueira, 783
Volta Redonda - RJ
Brasil
27.213-350

@taweili
Copy link
Owner

@taweili taweili commented Aug 3, 2013

Hi Daniel, Good job on the update. I have integrated them in the daniel branch https://github.com/taweili/ardublock/tree/daniel and will release a version for reviewed and tested by community today. In the meantime, I may have lost a few of your translation during the merge process. Could you update them in http://translate.ardublock.com Thanks.

@taweili taweili closed this Aug 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.