Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project modernizations #42

Merged
merged 1 commit into from
Dec 6, 2022
Merged

project modernizations #42

merged 1 commit into from
Dec 6, 2022

Conversation

tayloraswift
Copy link
Owner

@tayloraswift tayloraswift commented Dec 6, 2022

i used to think (in 2021) that this library was the pinnacle of accumulated swift experience… now all i see is terrible practices and overdue reforms…

by my personal standards today i think this library still needs a lot more work, but these changes should get us a long ways there:

  • adopt SPM-friendly directory structure
  • split up obscenely large files and organize by type instead of “concept”
  • stop using symlinked submodules
  • reduce reliance on “fancy” String descriptions, and move some of those APIs into the new TerminalColors module
  • (superficially) migrate test targets to Testing framework from swift-hash (TODO: actually rewrite the tests to use assertions instead of monkey-patching Result<Void, any Error>)
  • update CI so it is no longer 404-ing on unavailable nightly toolchains
  • expand CI coverage

…s, stop using symlinked submodules, superficially migrate test targets to Testing framework
@tayloraswift tayloraswift changed the title adopt SPM-friendly directory structure, split up obscenely large file… project modernizations Dec 6, 2022
@tayloraswift tayloraswift merged commit e732809 into master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant