Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i used to think (in 2021) that this library was the pinnacle of accumulated swift experience… now all i see is terrible practices and overdue reforms…
by my personal standards today i think this library still needs a lot more work, but these changes should get us a long ways there:
TerminalColorsmoduleTestingframework fromswift-hash(TODO: actually rewrite the tests to use assertions instead of monkey-patchingResult<Void, any Error>)