New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow key_count to be empty #46

Merged
merged 2 commits into from Jan 18, 2019

Conversation

2 participants
@omarroth
Copy link
Contributor

omarroth commented Jan 3, 2019

For ListObjectsV2, the key_count can sometimes be empty or non-existent. This is a quick fix to add a default value if it's not a valid integer.

Allow key_count to be empty
For `ListObjectsV2`, the `key_count` can sometimes be empty or non-existent. This is a quick fix to add a default value if it's not a valid integer.
@taylorfinnell

This comment has been minimized.

Copy link
Owner

taylorfinnell commented Jan 5, 2019

Thank you! This works even if KeyCount is absent from the response?

@omarroth

This comment has been minimized.

Copy link
Contributor

omarroth commented Jan 5, 2019

Yep!

@omarroth

This comment has been minimized.

Copy link
Contributor

omarroth commented Jan 18, 2019

I think you mean to merge patch-2 into master.

@taylorfinnell taylorfinnell merged commit 185088e into taylorfinnell:master Jan 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@taylorfinnell

This comment has been minimized.

Copy link
Owner

taylorfinnell commented Jan 18, 2019

Oops, no idea how that happened

@omarroth omarroth deleted the omarroth:patch-2 branch Jan 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment