Fix division operator because of Crystal 0.31.0 #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compute_default_part_size
ofMultipartFileUploader
returnsFloat64
right now on Crystal 0.31.0, on 0.30.1 it returnedInt32
:https://github.com/taylorfinnell/awscr-s3/blob/master/src/awscr-s3/multipart_file_uploader.cr#L60
This is because of this PR:
crystal-lang/crystal#8120
The division needs to be changed from
/
to//
to keep the type of the right side.