Fix continuation token invalid error #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listing S3 buckets with responses that require continuation tokens currently throws the exception below. This is typically only seen with S3 buckets with 1000's of objects to list.
Thanks to the investigation in this AWS forum post, this seems to be because of special characters in the obfuscated continuation token.
Passing token:
1TZkJICXgR0jZrdAHEJMonlSkBedCNzVrXzaGnw8ZBXsL5r5vhMtL7rJeJCTRvl1WYAoW27oMqx/JMbzac2uMqg==
Failing token:
1oDMtg+plckMHvLSZvcmKg6Gn5QYOEbCY9z/2gPv9gOXdHJRMSuQ/tibeJlExsXSBJwhmPaiDpMOQOF+c/49MmA==
Sometimes 1-3 requests pass through until it hits one with a plus in it and fails.
Running
URI.encode
withspace_to_plus: true
fixed this error.Looking for feedback on this approach and whether it is safe to run
space_to_plus: true
on all the query params or if we should scope it tocontinuation-token
.