Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog_ex's can throw exception #63

Closed
elnormous opened this issue Jun 6, 2018 · 2 comments
Closed

spdlog_ex's can throw exception #63

elnormous opened this issue Jun 6, 2018 · 2 comments

Comments

@elnormous
Copy link

You should not store std::string in the spdlog_ex class, because the std::move in the constructor can throw an exception and also rethrowing the spdlog_ex exception will try to copy the _msg which can also throw an exception.

@Taywee
Copy link
Owner

Taywee commented Jun 9, 2018

I think you've opened this in the wrong repository. This isn't spdlog.

@Taywee Taywee closed this as completed Jun 9, 2018
@elnormous
Copy link
Author

Oh, I am terribly sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants