New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Edit system configuration within Jethro #15

Closed
tbar0970 opened this Issue Feb 18, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@tbar0970
Owner

tbar0970 commented Feb 18, 2015

The DB credentials will always need to be in the conf.php file

But we could move all the other config into a settings table in the DB, so that it can be edited from within jethro. Saves on system-administrator effort.

Migration plan could be:

On init: Select all from settings table, and for any setting not already defined as a constant, define it as a constant. For any setting that is already defined as a constant, define(<setting_name>_DEFINED_IN_FILE).

In the settings page:
For each setting,
if <setting_name>_DEFINED_IN_FILE is set:

  • save the constant value to the DB
  • render a read-only interface
  • show an explanatory message inviting them to remove it from the conf.php file

else

  • show editable interface.
@vanoudt

This comment has been minimized.

Show comment
Hide comment
@vanoudt

vanoudt Feb 15, 2016

Contributor

Have started working on this...

Contributor

vanoudt commented Feb 15, 2016

Have started working on this...

@tbar0970

This comment has been minimized.

Show comment
Hide comment
@tbar0970

tbar0970 Feb 16, 2016

Owner

Great! Let me know if the backwards compatibility concept above needs further explanation (backwards compatibility will be important).

Owner

tbar0970 commented Feb 16, 2016

Great! Let me know if the backwards compatibility concept above needs further explanation (backwards compatibility will be important).

tbar0970 pushed a commit that referenced this issue Jan 31, 2017

tbar0970
Progress on Issue #15 - remove the LOCK_CLEANUP_PROBABILITY setting t…
…hat nobody cares about, and make LOCK_LENGTH an integer for simpler config.

@tbar0970 tbar0970 closed this in acd6f01 Feb 25, 2017

tbar0970 pushed a commit that referenced this issue Feb 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment