Issue #425 - Failure when user has no custom_field table entries

[thesle]

Apply fix to SQL upgrade script. Identified issue over the weekend while upgrading a system.

[tbar0970]

Thanks!

[thesle]

Hi Tom, I'm just discovery this GitHub process. (I'm a professional dev, but have always used on-site VC.) I'm working with a church that use the software and I'm trying to get the system running on PHP7 and current MySQL versions. I've got most of it running after having troubles with a couple of MySQL legacy options (NO_ZERO_DATE, ONLY_FULL_GROUP_BY). However, I came across an issue with the status_last_changed colmun, where MySQL won't accept the 'c' date format. I've grabbed a local copy, solved the issue and then made the change in GitHub (I couldn't push back to GitHub, got a 403). You'll see pull request #428. I'll leave you to decide if this is a change you want in the code, or if you want to keep UTC timestamps on records. However, am I following the correct process here? Given that MySQL is getting stricter by default, I'd be happy to start looking at all the SQL code and update it so that it can run in these stricter modes if that's of value. I'm experienced in PHP as well, but need to get my head around the codebase a little, as it doesn't appear to be a strict framework. Blessings, Conrad

[tbar0970]

Hi Conrad

(NB this thread exists online as well as via email!)

Great to have your contributions here. The process you've been following is perfect, and it's great to have just small changes in each pull request so it's easy to review. Please do continue improving mysql compatibility.

You're right that Jethro isn't built on a standard framework (it pre-dates most frameworks!). In general the idea is that most database queries come from the db_object class (or a subclass), which follows the active record pattern. Most presentation logic should be in one of the "view" subclasses, although db_objects also render low-level widgets to display/edit their properties.

Tom