Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added command line flag to add logging/concurrency #2

Closed
wants to merge 6 commits into
from

Conversation

Projects
None yet
2 participants
Collaborator

detiber commented Jul 26, 2011

No description provided.

tbielawa and others added some commits Jul 25, 2011

@tbielawa @detiber tbielawa Exit/continue the main load-loop sooner so we can validate YAML scrip…
…ts and not blow up when not ran on a minion/overlord (like during testing...)
13f1d43
Jason DeTiberus Added command line flag to add logging 7dbef27
Owner

tbielawa commented Jul 27, 2011

Can you fix this up so it comes back pep8 clean?

<tbielawa>@(griddle)[~/Projects/Taboot] 22:21:58  (newargs) 
$ pep8 taboot/cli.py 
taboot/cli.py:26:1: E302 expected 2 blank lines, found 1
taboot/cli.py:92:19: E225 missing whitespace around operator
taboot/cli.py:97:80: E501 line too long (96 characters)
taboot/cli.py:126:42: E231 missing whitespace after ','
taboot/cli.py:133:87: W291 trailing whitespace
taboot/cli.py:155:53: E202 whitespace before ']' 

pep8 is in the python-pep8 package.

Run pep8 like this to get verbose explanations & examples.

 pep8 --show-pep8 taboot/cli.py
Owner

tbielawa commented Jul 27, 2011

If you're feeling up to it you should fetch and rebase your fork off of tbielawa/master, I've made a few commits since you forked.

Collaborator

detiber commented Jul 27, 2011

PEP8 fixes are in place. There is no only one error for line too long, but that would mess up the formatting on the -h flag.

Jason DeTiberus Added -C flag for Concurrency, Fixed an error when -L wasn't specifie…
…d and added CLIOutput when -L is specified and logging wasn't already set
328e925
Collaborator

detiber commented Jul 27, 2011

3 new items:
-Fixed up an issue when -L wasn't specified.
-Made sure to add CLIOutput when -L is specified and output is not specified in script.
-Added -C flag for concurrency override

Owner

tbielawa commented Jul 27, 2011

Protip: you can break long strings without interrupting formatting like this:

def oh_hi():
     print "this string is getting longer this string is getting longer this string is \
getting longer this string is getting longer"
Jason DeTiberus More PEP8 fixes bf55377
Collaborator

detiber commented Jul 27, 2011

Okay, it now passes pep8 cleanly

Owner

tbielawa commented Jul 28, 2011

Looks great. Rebased and merged into master.

Thank you!

@tbielawa tbielawa closed this Jul 28, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment