Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

String error property is set, making error in third party module #2

Open
zazabe opened this Issue · 1 comment

2 participants

@zazabe

String object has a strange behavior when rconsole is present:

$ node
> "toto".error
undefined
> require('rconsole')
> "toto".error
'\u001b[31mtoto\u001b[39m'

I'm using a module making a test on parsed error property, this module is broken because of this strange issue...

consider an API (Mailchimp in some cases) with response like that :

  • failed: {"error":"error message"}
  • successful: "value"
var data = JSON.parse(response);
// failed : data.error = "\u001b[31value\u001b[39m"
// successful : data.error = "error message"

if(data.error){...} //always true

I think the problem is to use https://github.com/Marak/colors.js, with String.prototype extension, but i suspect rconsole to do the same by setting error property on objects.

Is it smell not good or I miss something ?

@chrisdew

+1, I've also been bitten by this. I had a variable which either referred to a string or an object with an 'error' property. I was unable to simply check that thing.error was non-false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.