Add .has method for checking membership. #2

Merged
merged 2 commits into from Mar 1, 2013

Conversation

Projects
None yet
2 participants
Contributor

chakrit commented Mar 1, 2013

For checking membership. With 2 tests.

Also I think you should split up the tests into categories.

Owner

tblobaum commented Mar 1, 2013

Thanks. Did you test members.has?

Contributor

chakrit commented Mar 1, 2013

@tblobaum yep, but only 2 tests. check the files changed. not sure if I should add more?

Owner

tblobaum commented Mar 1, 2013

A test for members.has would be good

Contributor

chakrit commented Mar 1, 2013

@tblobaum ^ there you go. all tests passing on my machine.

tblobaum added a commit that referenced this pull request Mar 1, 2013

Merge pull request #2 from chakrit/feature/member.has
Add .has method for checking membership.

@tblobaum tblobaum merged commit 70e5011 into tblobaum:master Mar 1, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment