Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

halt_system mismatch in arg count #383

Closed
MatthewMerrill opened this issue May 14, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@MatthewMerrill
Copy link
Contributor

commented May 14, 2019

7a45420 introduces build error when I run ninja in build

../kernel/exit.c: In function ‘halt_system’:
../kernel/exit.c:124:1: error: number of arguments doesn’t match prototype
 static void halt_system() {
 ^~~~~~
../kernel/exit.c:9:13: error: prototype declaration
 static void halt_system(int status);
             ^~~~~~~~~~~

status argument was removed from the halt_system's definition but the prototype still had that argument.

Fix could be to remove the argument from the prototype or add it back but ignored?

@tbodt

This comment has been minimized.

Copy link
Owner

commented May 15, 2019

Fix is to take out the argument. It works on my machine so you'll have to do it.

@fernandotcl

This comment has been minimized.

Copy link

commented May 15, 2019

Actually, what you probably want is halt_system(void), which actually means no parameters. halt_system() means it takes any combination of parameters.

@tbodt tbodt closed this in #384 May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.