Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update jasmine and qunit sample test runners #189

merged 3 commits into from Jan 5, 2013


None yet
3 participants

jreyes33 commented Jan 3, 2013

This PR fixes the sample test runners, which were still outdated (weren't using jam). It should solve issue #187.

I've also renamed the example jasmine spec to example.spec.js so that jasmine-node picks it up.

@SBoudrias SBoudrias commented on the diff Jan 4, 2013

<!-- Load application -->
<script data-main="../../app/config"
- src="../../assets/js/libs/require.js"></script>
+ src="../../vendor/jam/require.js"></script>

SBoudrias Jan 4, 2013


I'm wondering if this can break the test as the config (and paths configuration) may not be loaded (asynchronous loading) when the specs are runned lower.


tbranyen Jan 5, 2013


I think it's possible, we could probably require the router or something to ensure its been loaded.

@jreyes33 jreyes33 referenced this pull request Jan 4, 2013


Testing documentation #91


tbranyen commented Jan 5, 2013

Awesome thanks for updating this!

@tbranyen tbranyen added a commit that referenced this pull request Jan 5, 2013

@tbranyen tbranyen Merge pull request #189 from jreyes33/master
Update jasmine and qunit sample test runners

@tbranyen tbranyen merged commit 437d0e3 into tbranyen:master Jan 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment