Update test to prevent asynchronous config from breaking test #191

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

SBoudrias commented Jan 6, 2013

Previously, it was possible that the test started before the config.js file was loaded. This could create bugs as some shim config and paths config could break modules definitions. Now, the config is always loaded.

I had to declare require.config before adding the config script tag to make sure the baseUrl is set correctly for the deps array to work.

genexp commented Jan 11, 2013

+1

Contributor

SBoudrias commented Jan 20, 2013

Just amend my commit with a basic fix. jam config and the config files should both be loaded after the baseUrl is setup as both depends on this path to be defined before.

Owner

tbranyen commented Apr 7, 2013

hrm you're calling require before loading require.js. I've incorporated a similar fix in the wip branch.

@tbranyen tbranyen closed this Apr 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment