Raise an event when all views in a given selector are closed

[gjlubbertsen]

Pull request for fix for issue:
https://github.com/tbranyen/backbone.layoutmanager/issues/453

[tbranyen]

Please follow the existing code style and do not add your own. See:

https://github.com/tbranyen/backbone.layoutmanager/blob/master/CONTRIBUTING.md#code-style

[tbranyen]

Looks good otherwise 👍

[gjlubbertsen]

ok. Will fix the same

[tbranyen]

We use 2 space soft tabs, please adjust.

[tbranyen]

Would a better event name be empty?

manager.parent.trigger("empty");

//...

view.on("empty", function(selector) {

});

[gjlubbertsen]

I like it. Little less speaking but think it covers what happened.

[tbranyen]

Awesome, once those changes are done, I think it's good to go, but I'd like a second look from @STRML @SBoudrias @jugglinmike or @ssafejava.

[gjlubbertsen]

Ok. Lets see what they think about it.

[gjlubbertsen]

wrote initial documentation:
https://github.com/tbranyen/backbone.layoutmanager/wiki/Events

[jugglinmike]

@gjlubbertsen Might want to hold off on modifying the wiki at least until it lands. Or even better: until we release a new version.

[gjlubbertsen]

Fine.

[gjlubbertsen]

reverted it: list here for reference.

empty

If you have a layout with sub-views you might want to be informed when the last view in a selector is removed.
In that case the empty event is triggered. This allows your layout to hide unnecessary parts of the layout.

myLayout.on("empty", function(selector) {
  if (selector == "#rightpanel") {
    $("#rightcontainer").hide();
  }
});

[gjlubbertsen]

When can we expect it to board the master ?

[tbranyen]

Right now ;-)

[gjlubbertsen]

Thanks!

When do we post the documentation changes?