Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEditorial: consider renaming IteratorComplete and IteratorValue #1040
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
kmiller68
Dec 4, 2017
This seems reasonable to me. I agree that the current notation could be confusing.
kmiller68
commented
Dec 4, 2017
|
This seems reasonable to me. I agree that the current notation could be confusing. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
|
Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
domenic commentedDec 4, 2017
The current menagerie of iterator abstract operations is confusing because half of them take iterator records and half of them take IterResult objects. But, both are prefixed with "Iterator".
I'd suggest renaming "IteratorComplete" and "IteratorValue" to e.g. "IterResultDone" and "IterResultValue".