Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPRs policy #1061
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
No. #666 says that it's blocked on test262 tests. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
raulsebastianmihaila
Jan 6, 2018
@ljharb Does that mean that it can take 20 years for a PR that achieved consensus to be merged?
raulsebastianmihaila
commented
Jan 6, 2018
|
@ljharb Does that mean that it can take 20 years for a PR that achieved consensus to be merged? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
littledan
Jan 6, 2018
Member
@raulsebastianmihaila That PR is pretty tricky; if we merge it without good test262 tests, I'm worried implementations might not get everything right. Test262 has been very useful in the implementation of Proxies across engines so far. If you want to push this feature forward, contributing the tests could help get it landed in less than 20 years :)
|
@raulsebastianmihaila That PR is pretty tricky; if we merge it without good test262 tests, I'm worried implementations might not get everything right. Test262 has been very useful in the implementation of Proxies across engines so far. If you want to push this feature forward, contributing the tests could help get it landed in less than 20 years :) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
raulsebastianmihaila
Jan 6, 2018
@littledan Unfortunatelly I don't have enough time, working full time as a JS dev, having to write tests for my own JS framework, taking bachata and salsa lessons etc. :) Joking aside, is TC39 in general lacking resources for testing? Also, being a tricky PR it would probably be a good idea for an experienced Test262 person to take care of this one.
raulsebastianmihaila
commented
Jan 6, 2018
|
@littledan Unfortunatelly I don't have enough time, working full time as a JS dev, having to write tests for my own JS framework, taking bachata and salsa lessons etc. :) Joking aside, is TC39 in general lacking resources for testing? Also, being a tricky PR it would probably be a good idea for an experienced Test262 person to take care of this one. |
raulsebastianmihaila commentedJan 6, 2018
Should TC39 have a policy w.r.t the time frame in which a PR should be merged? There's currently an open PR, which has consensus, for a confirmed bug that was reported one year and a half ago.