New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EscapeRegExpPattern: references to Pattern omit setting for N #1076

Open
jmdyck opened this Issue Jan 24, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@jmdyck
Collaborator

jmdyck commented Jan 24, 2018

In the abstract operation EscapeRegExpPattern, step 1 says

Let _S_ be a String in the form of a |Pattern[~U]| (|Pattern[+U]| if _F_ contains `"u"`)  ...

However, since "RegExp named capture groups" was merged (95ec0c6), Pattern now takes an additional grammatical parameter, N. Thus, the above references to Pattern must be updated, and possibly the logic extended to decide between ~N and +N.

(attn @mathiasbynens)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment