Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upEscapeRegExpPattern: references to Pattern omit setting for N #1076
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jmdyck commentedJan 24, 2018
In the abstract operation EscapeRegExpPattern, step 1 says
However, since "RegExp named capture groups" was merged (95ec0c6), Pattern now takes an additional grammatical parameter, N. Thus, the above references to Pattern must be updated, and possibly the logic extended to decide between ~N and +N.
(attn @mathiasbynens)