/ecma262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing [?U] for ClassEscape :: CharacterClassEscape #1082

Closed
anba opened this Issue Jan 26, 2018 · 5 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anba @jmdyck @bterlson
@anba
Contributor

anba commented Jan 26, 2018

CharacterClassEscape now also has [U], so it needs to be passed from ClassEscape.
@jmdyck

This comment has been minimized.

Show comment
Hide comment
@jmdyck

jmdyck Jan 26, 2018

Collaborator

And from AtomEscape.
See ee6c6b6
Collaborator

jmdyck commented Jan 26, 2018

And from AtomEscape.
See ee6c6b6
@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Feb 12, 2018

Member

Also the Annex B definitions of AtomEscape and ClassEscape, presumably.
Member

bterlson commented Feb 12, 2018

Also the Annex B definitions of AtomEscape and ClassEscape, presumably.
@jmdyck

This comment has been minimized.

Show comment
Hide comment
@jmdyck

jmdyck Feb 12, 2018

Collaborator

Yup, ee6c6b6 has got those too.
Collaborator

jmdyck commented Feb 12, 2018

Yup, ee6c6b6 has got those too.
@bterlson

This comment has been minimized.

Show comment
Hide comment
@bterlson

bterlson Feb 12, 2018

Member

Ahh I missed that in the midst of @jmdyck's editorial PR. I guess I'll splice out my duplicate commit there.
Member

bterlson commented Feb 12, 2018

Ahh I missed that in the midst of @jmdyck's editorial PR. I guess I'll splice out my duplicate commit there.
@anba

This comment has been minimized.

Show comment
Hide comment
@anba

anba Apr 13, 2018

Contributor

Looks like it's fixed now. Thanks @jmdyck !
Contributor

anba commented Apr 13, 2018

Looks like it's fixed now. Thanks @jmdyck !

@anba anba closed this Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment