/ecma262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should remove unnecessary [[Extensible]] assignments #1201

Closed
bmeck opened this Issue May 22, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@bmeck @rkirsling
@bmeck
Member

bmeck commented May 22, 2018

Default behavior is for it to be true per https://tc39.github.io/ecma262/#sec-ecmascript-standard-built-in-objects , but lots of builtins specify it to be true. This can lead to some confusion and thinking that true is not the default.

@bmeck bmeck self-assigned this May 22, 2018

@bmeck bmeck added needs editorial changes good first patch labels May 22, 2018

@rkirsling

This comment has been minimized.

Show comment
Hide comment
@rkirsling

rkirsling Jun 4, 2018

Member

@bmeck: I was looking for a good first patch to tackle, but noticed that you've also self-assigned here. Do you mind if I submit a PR for this?
Member

rkirsling commented Jun 4, 2018

@bmeck: I was looking for a good first patch to tackle, but noticed that you've also self-assigned here. Do you mind if I submit a PR for this?
@bmeck

This comment has been minimized.

Show comment
Hide comment
@bmeck

bmeck Jun 4, 2018

Member

@rkirsling feel free to make the PR, I accidentally set myself to this wehn making it and then changed it to be good first patch XD.
Member

bmeck commented Jun 4, 2018

@rkirsling feel free to make the PR, I accidentally set myself to this wehn making it and then changed it to be good first patch XD.

@bmeck bmeck removed their assignment Jun 4, 2018

@rkirsling rkirsling referenced this issue Jun 4, 2018

Merged

Editorial: Don't explicitly set [[Extensible]] to true #1212

@ljharb ljharb closed this in #1212 Jun 4, 2018

@rkirsling rkirsling referenced this issue Jun 6, 2018

Merged

Editorial: Built-ins needn't initialize [[Extensible]] to true #1215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment