/ecma262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ununsed variable in 9.4.2.4 ArraySetLength #1230

Closed
cpansprout opened this Issue Jun 15, 2018 · 0 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@cpansprout @ljharb
@cpansprout

cpansprout commented Jun 15, 2018

Steps 16.c.iii-iv. read:

iii. Let succeeded be ! OrdinaryDefineOwnProperty(A, "length", newLenDesc).
iv. Return false.

The value of that succeeded variable is never used, which is a little confusing.

@ljharb ljharb added needs editorial changes good first patch labels Jun 15, 2018

ryzokuken added a commit to ryzokuken/ecma262 that referenced this issue Jun 16, 2018

@ryzokuken
Editorial: remove unused variables in ArraySetLength 
Remove the unused variable (named `succeeded`) in Steps 16.c.iii-iv. in
Section 9.4.2.4, which describes the abstract operation ArraySetLength.

Fixes: tc39#1230
Verified
This commit was signed with a verified signature.
@ryzokuken ryzokuken Ujjwal Sharma
GPG key ID: 1FD3B47B83F46621 Learn about signing commits
55b0c61

@ryzokuken ryzokuken referenced this issue Jun 16, 2018

Merged

Editorial: remove unused variables in ArraySetLength #1231

ljharb added a commit to ryzokuken/ecma262 that referenced this issue Jun 16, 2018

@ryzokuken @ljharb
Editorial: remove unused variables in ArraySetLength 
Remove the unused variable (named `succeeded`) in Steps 16.c.iii-iv. in
Section 9.4.2.4, which describes the abstract operation ArraySetLength.

Fixes: tc39#1230
Verified
This commit was signed with a verified signature.
@ljharb ljharb Jordan Harband
GPG key ID: 64A196AEE0916D55 Learn about signing commits
21b60c0

@bterlson bterlson closed this in #1231 Jun 18, 2018

bterlson added a commit that referenced this issue Jun 18, 2018

@ryzokuken @bterlson
Editorial: remove unused variables in ArraySetLength (#1231) 
Remove the unused variable (named `succeeded`) in Steps 16.c.iii-iv. in
Section 9.4.2.4, which describes the abstract operation ArraySetLength.

Fixes: #1230
727656a

ljharb added a commit to ljharb/ecma262 that referenced this issue Jun 19, 2018

@ryzokuken @ljharb
Editorial: remove unused variables in ArraySetLength (tc39#1231) 
Remove the unused variable (named `succeeded`) in Steps 16.c.iii-iv. in
Section 9.4.2.4, which describes the abstract operation ArraySetLength.

Fixes: tc39#1230
Verified
This commit was signed with a verified signature.
@ljharb ljharb Jordan Harband
GPG key ID: 64A196AEE0916D55 Learn about signing commits
Loading status checks…
98d5a49

bterlson added a commit that referenced this issue Jun 20, 2018

@ljharb @bterlson
ES2018: more editorial changes (#1238) 
* Editorial: remove useless es6num comments (#1237)

* Editorial: fix typo in Section 6.4.2 (#1233)

Fix a typo in Section 6.4.2, which concerns the Reference Specification
Type in the definition for a "Super Reference".

represents => represent

Fixes: #1229

* Editorial: remove unused variables in ArraySetLength (#1231)

Remove the unused variable (named `succeeded`) in Steps 16.c.iii-iv. in
Section 9.4.2.4, which describes the abstract operation ArraySetLength.

Fixes: #1230
8e34363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment